Create ui-components package #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
nitaliano
reviewed
Jan 10, 2024
| "main": "dist/index.js", | ||
| "types": "dist/index.d.ts", | ||
| "scripts": { | ||
| "build": "vite build && tsc -p tsconfig.json", |
There was a problem hiding this comment.
something to consider in the future. i ended up using tsup
instead of just vite. felt like it gives more control and we could reuse it for backend packagesThere was a problem hiding this comment.
u think it's worth to change? i'm not too deep on what the difference is
There was a problem hiding this comment.
nah don't worry about it right now, something we can talk about as a team to decide what we want to do. The main difference atleast from what i noticed is tsup gives more control over the *.d.ts files that get generated. Once we add more components we can see both ways work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Boiler plate code to create the
ui-componentspackage. verified that building with vite works when starting up thebridge-app& test component loads nicely 💯